gtk3: add missing libXdamage #207821
Merged
gtk3: add missing libXdamage #207821
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is regressed in cd65dfa because Built MATE VM on https://github.com/bobby285271/nixpkgs/commits/mate-test:
|
trofi
approved these changes
Dec 26, 2022
|
Ugh, I wish they would use Might as well add |
libXdamage is an optional dependency, however this is needed for XEmbed tray icons on MATE to work properly. This is already enabled in gtk4. https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.36/meson.build#L583 https://gitlab.gnome.org/search?search=xdamage&project_id=665&group_id=8&search_code=true&repository_ref=gtk-3-24 Also explicitly add libXfixes since gtk3 also optionally directly depends on it. https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.36/meson.build#L577
bobby285271
force-pushed
the
gtk3-libXdamage
branch
from
2f1b230
to
6257a5a
Compare
Mindavi
approved these changes
Dec 27, 2022
romildo
approved these changes
Dec 27, 2022
|
Thanks. |
|
I just saw this issue on some user's screenshot1 and noticed that I forget to take care of the backport 😓 Footnotes |
1 task
|
Successfully created backport PR for |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in this PR:
libXdamage is an optional dependency, however this is needed for XEmbed tray icons on MATE to work properly. This is already enabled in all other distributions (1 2 3 4 5) except us, this is also already required in gtk4.
Things done